refactor(carousel): Tab order of carousel items - #17456
Open
rkaraivanov wants to merge 2 commits into
Open
Conversation
Changed the default tab order of the component, focus now flows starting with its indicator container, navigation buttons, or the first focusable element in the active slide, whichever is available.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the IgxCarouselComponent template to change the keyboard tab/focus order for improved accessibility and aligns the release notes to document the behavioral change.
Changes:
- Reordered the carousel indicators before the navigation buttons in the DOM to make indicators appear earlier in the tab sequence.
- Added a new changelog entry documenting the carousel’s updated default tab order.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| projects/igniteui-angular/carousel/src/carousel/carousel.component.html | Moves the indicators block before navigation buttons to change the default tab sequence. |
| CHANGELOG.md | Documents the carousel tab-order behavioral change (and includes minor formatting/whitespace adjustments nearby). |
Comment on lines
+19
to
+21
| @if (showIndicators) { | ||
| <div [ngClass]="indicatorsClass" [attr.role]="'tablist'" (keyup)="handleKeyUp($event)" (focusout)="handleFocusOut($event)" (click)="handleClick()" (keydown)="handleKeydown($event)"> | ||
| @for (slide of slides; track slide) { |
Contributor
There was a problem hiding this comment.
Added three specs to carousel.component.spec.ts inside describe('Base Tests: ...') to lock in the expected tab order:
should render indicators before navigation buttons in the DOM to preserve tab order— usescompareDocumentPositionto assert the indicators container precedes both the prev and next buttons in DOM order (indicators → prev → next).should have active indicator as first keyboard-focusable element when navigation is disabled— verifies the active indicator hastabindex="0", inactive ones havetabindex="-1", and the indicators container precedes the active slide when navigation buttons are absent.should have navigation buttons precede active slide when indicators are hidden— verifies nav buttons appear before the active slide in the DOM when indicators are hidden.
Comment on lines
+75
to
+76
| - `IgxCarouselComponent` | ||
| - Changed the default tab order of the component, focus now flows starting with its indicator container, navigation buttons, or the first focusable element in the active slide, whichever is available. |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
projects/igniteui-angular/carousel/src/carousel/carousel.component.html:21
- The PR changes focus/tab order by reordering focusable DOM (indicators now come before navigation buttons), but there is no accompanying unit test to prevent regressions. Since
carousel.component.spec.tsalready covers keyboard navigation and indicators focus, please add a spec that verifies the tab sequence/DOM order (e.g., active indicator/tab -> prev -> next -> first focusable in active slide when present), and the fallback behavior when indicators/navigation are disabled.
@if (showIndicators) {
<div [ngClass]="indicatorsClass" [attr.role]="'tablist'" (keyup)="handleKeyUp($event)" (focusout)="handleFocusOut($event)" (click)="handleClick()" (keydown)="handleKeydown($event)">
@for (slide of slides; track slide) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed the default tab order of the component,
focus now flows starting with its indicator container, navigation buttons, or the first focusable element in the active slide, whichever is available.
Motivation / Context
Related to #2291.
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)