Add out-of-tree model plugin interface#441
Open
whjthu wants to merge 1 commit into
Open
Conversation
e9b8dda to
33730e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
python/infinilm/plugins/*, centered onModelSpec,register_model,load_plugin, config adaptation, processor selection, and checkpoint weight remapping.python/infinilm/infer_engine.py, so external HuggingFacemodel_typevalues can map to existing InfiniLM C++ backends without adding model definitions to the core repo.python/infinilm/modeling_utils.pyandpython/infinilm/processors/__init__.py, while preserving the existing built-in remapper and processor paths.csrc/models/backend_plugin_loader.*,csrc/pybind11/bindings.cc, andpython/infinilm/backend_plugins.py.python/infinilm/__init__.pylighter by lazily importing heavier runtime objects, so plugin-only workflows can importinfinilm.pluginswithout eagerly initializing the full runtime stack.setup.pyso newly added Python subpackages are included in installs.Motivation
InfiniLM already supports multiple model families, but adding every new model-specific config adapter, processor choice, or checkpoint key conversion directly into the core engine repo does not scale well. Many model families are close enough to existing InfiniLM backends that they only need load-time metadata adaptation, not new inference kernels.
This PR introduces a small extension surface that lets external repositories define model integration logic out of tree:
model_typeto an existing InfiniLM backend;config.jsonfields before C++ engine initialization;The default behavior remains unchanged when no plugin is loaded: config adaptation is a no-op, plugin weight remapping is a no-op, and existing built-in processors/remappers continue to run as before.
This is not intended as a performance change. Python plugin callbacks run during config, processor, or weight loading only; they are not part of the token-by-token inference hot path.
Type of Change
feat— new feature / new modelfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changesTest Results of Involved Models on Supported Platforms (Please attach screenshots)
Benchmark / Performance Impact
Notes for Reviewers
Checklist
Title, Branch, and Commits
feat(nvidia): …,fix(cuda/gemm): …).<type>/xxx-yyyy-zzzzwhere<type>matches the PR title's Conventional Commits type and words are joined with hyphens (seeCONTRIBUTING.md§Branches).CONTRIBUTING.md§Pull Requests).main— the branch is rebased cleanly on top of the currentmain.fixup!/squash!/wipcommits remain.Scope and Design
CONTRIBUTING.md§Code/General).printf/std::cout/print(...)left behind, orTODOwithout an owner and issue link.General Code Hygiene (applies to all languages)
CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).the `seqlens_k` tensor) (CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General; §Python).C++ Specific (if C++ files changed)
CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).new/delete; RAII / smart pointers / existing allocators are used.scripts/format.py.csrc/models/llama_legacy/.Python Specific (if Python files changed)
CONTRIBUTING.md§Python).CONTRIBUTING.md§Python).scripts/format.py.python/infinilm/auto_config.py.Testing
examples/test_infer.py), or specify the reason for skipping.examples/bench.py), or specify the reason for skipping.test/bench/test_benchmark.py), or specify the reason for skipping.python/infinilm/server/inference_server.py+scripts/test_perf.py), or specify the reason for skipping.Build, CI, and Tooling
Documentation
README.md,CONTRIBUTING.md, or inline docs updated when behavior, build flags, or developer workflow changed.!orBREAKING CHANGE:footer.Security and Safety