feat: rwkv5 world text#449
Open
wooway777 wants to merge 2 commits into
Open
Conversation
| elif sampling_params.max_tokens is None: | ||
| sampling_params = sampling_params.clone() | ||
| sampling_params.max_tokens = self.config.max_tokens | ||
| if ( |
Collaborator
There was a problem hiding this comment.
通用的流程里面,不应该出现对模型 "rwkv5"的特判。 这个能修改么
|
|
||
|
|
||
| def _apply_model_generation_defaults(config: EngineConfig, engine: "LLMEngine") -> None: | ||
| model_engine = engine.model_runner.model_engine |
Collaborator
There was a problem hiding this comment.
觉得优先级不对。 应该命令行参数 > generation_config.json 。 这里正好反过来了
Collaborator
There was a problem hiding this comment.
这里可以单独提交一个pr修改。
(1) 首先的将默认的top_k 修改为None
(2) 如果有命令行参数就用命令行的topk的值
(3) 命令行不传的话,就使用generation_config.json(文件存在)的模型提供的默认值
(4) 如果generation_config.json文件不存在的话,再赋值为1 1 1.0
| ) | ||
| else: | ||
| normalized_conversation.append(message) | ||
| if self.tokenizer.chat_template is None: |
Collaborator
There was a problem hiding this comment.
baichuan等模型没有 chat_template时,就时新建了一个basic_llm_processor.py文件。 这里却直接修改了basic_llm_processor.py
23eb24b to
728f099
Compare
728f099 to
3b92df7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Closes #
Type of Change
feat— new feature / new modelfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changesTest Results of Involved Models on Supported Platforms (Please attach screenshots)
Benchmark / Performance Impact
Notes for Reviewers
Checklist
Title, Branch, and Commits
feat(nvidia): …,fix(cuda/gemm): …).<type>/xxx-yyyy-zzzzwhere<type>matches the PR title's Conventional Commits type and words are joined with hyphens (seeCONTRIBUTING.md§Branches).CONTRIBUTING.md§Pull Requests).main— the branch is rebased cleanly on top of the currentmain.fixup!/squash!/wipcommits remain.Scope and Design
CONTRIBUTING.md§Code/General).printf/std::cout/print(...)left behind, orTODOwithout an owner and issue link.General Code Hygiene (applies to all languages)
CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).the `seqlens_k` tensor) (CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General; §Python).C++ Specific (if C++ files changed)
CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).new/delete; RAII / smart pointers / existing allocators are used.scripts/format.py.csrc/models/llama_legacy/.Python Specific (if Python files changed)
CONTRIBUTING.md§Python).CONTRIBUTING.md§Python).scripts/format.py.python/infinilm/auto_config.py.Testing
examples/test_infer.py), or specify the reason for skipping.examples/bench.py), or specify the reason for skipping.test/bench/test_benchmark.py), or specify the reason for skipping.python/infinilm/server/inference_server.py+scripts/test_perf.py), or specify the reason for skipping.Build, CI, and Tooling
Documentation
README.md,CONTRIBUTING.md, or inline docs updated when behavior, build flags, or developer workflow changed.!orBREAKING CHANGE:footer.Security and Safety