fix: rename minValue/maxValue to minimum/maximum in moldb.yaml#16
Merged
Conversation
The job-definition schema only accepts minimum/maximum, not minValue/maxValue. #14 renamed these everywhere else but missed moldb.yaml, which meant jote couldn't even parse this manifest (schema validation failed before any test could be discovered). Verified with jote --manifest data-manager/manifest-moldb.yaml --dry-run: now finds and dry-run-passes all 12 tests. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-manager/moldb.yamlstill used the oldminValue/maxValuekeys, which the job-definition schema no longer accepts (onlyminimum/maximumare valid). minValue -> minimum #14 renamed these across the other job definitions but missed this file.jote --manifest data-manager/manifest-moldb.yamlfailed schema validation before any test could even be discovered (and this is why CI'stest.yamlworkflow excludes this manifest from itsjote --dry-runlist).minimum/maximum.Test plan
jote --manifest data-manager/manifest-moldb.yaml --dry-run --allow-no-tests→ now finds and dry-run-passes all 12 tests (previously failed withAdditional properties are not allowed ('maxValue', 'minValue' were unexpected))docker-compose-postgres.yaml) — not exercised here🤖 Generated with Claude Code