Geometry Factory for Muon Calorimeter#1302
Open
ethancline wants to merge 24 commits into
Open
Conversation
… dedicated mu package
ethancline
requested review from
baltzell,
drewkenjo and
raffaelladevita
as code owners
baltzell
reviewed
Jun 3, 2026
baltzell
reviewed
Jun 3, 2026
raffaelladevita
requested changes
Jun 4, 2026
| return paddleVolumes; | ||
| } | ||
|
|
||
| public G4Box getComponent(int sector, int layer, int paddle) { |
Collaborator
There was a problem hiding this comment.
zg4Box should be replaced with G4Trd
| private final double CrmaxD = CrmaxU + Clength*Math.tan(CexitAngle); | ||
|
|
||
|
|
||
| private final double nplanes = 4; |
Collaborator
There was a problem hiding this comment.
is the polucone containing the crystals created?
Collaborator
Author
There was a problem hiding this comment.
I'm not sure what you mean by the polycone containing the crystals? I create the crystals as trapezoids, and place them in the mother volume directly. I can place them in another volume if you like.
Collaborator
There was a problem hiding this comment.
In gemc, the crystals were placed inside a polycone, in order to be able to apply global shifts, for example. Since the dimensions depend on the crystal size and number, it would be good to create this volume here.
Collaborator
|
See #1317 |
remove unused imports, run auto-formatter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial implementation of Muon Calorimeter Geometry Factory for the future ddvcs experiment.