Implement Layer and Wire alignment#1310
Merged
baltzell merged 14 commits intoJun 15, 2026
Merged
Conversation
Collaborator
There was a problem hiding this comment.
Bug in AlertDCWireIdentifier(int,int,int) (File: [AlertDCWireIdentifier.java:34-39]):
public AlertDCWireIdentifier(int _sector, int _layer, int _component) {
sector = _sector;
layer = _layer;
component = _layer;
num = slc2wire(_sector, _layer, _component);
}component is assigned _layer
I can't say if this is correct or not:
public void detectorChanged(int run) {
factory = (new AlertDCFactory()).createDetectorCLAS(new DatabaseConstantProvider(run,"default"));
DatabaseConstantProvider cp = new DatabaseConstantProvider(run, "default");
cp.loadTable("/geometry/alert/ahdc/layer_alignment");
cp.loadTable("/geometry/alert/ahdc/wire_alignment");
AHDCdet = (new AlertDCFactory()).createDetectorCLAS(cp);
}I guess @baltzell needs to look into that.
Collaborator
Author
|
Thank you @mathieuouillon, I've fixed the bug in the constructor. |
Collaborator
|
@mathieuouillon this DatabaseConstantProvider initialization paradigm for geometry is around and used in coatjava. |
baltzell
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement wire and layer alignment
AlertDCFactoryto read these tablesresidual_LRin AHDC::hits, our alignment observableThings of particular importance: I have modified the
detectorChanged()method in order to load the new tables, is it the right way to do that?