Sorting: consistently use alg keyword for algorithm selection#92
Open
maleadt wants to merge 1 commit into
Open
Sorting: consistently use alg keyword for algorithm selection#92maleadt wants to merge 1 commit into
alg keyword for algorithm selection#92maleadt wants to merge 1 commit into
Conversation
Make sort!/sort/sortperm!/sortperm the documented surface for choosing a sort implementation via alg=. Remove the docs entries for the algorithm-specific helpers (merge_sort!, sample_sort!, etc.) so alg= is the blessed selection API; the helpers remain available as unexported internals. Update the binary-search example to use the alg keyword.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I liked the way this was done with accumulate.
cc @vchuravy