Fix KEEPER_SSL_CERT_FILE ignored for HTTP SSL verification#2173
Open
amangalampalli-ks wants to merge 3 commits into
Open
Fix KEEPER_SSL_CERT_FILE ignored for HTTP SSL verification#2173amangalampalli-ks wants to merge 3 commits into
amangalampalli-ks wants to merge 3 commits into
Conversation
…PAM, tunnel HTTP, and DAG (#2172)
8e3431c to
90b9f6e
Compare
idimov-keeper
requested changes
Jun 29, 2026
Contributor
There was a problem hiding this comment.
- PAM SaaS GitHub has only partial coverage -
VERIFY_SSL=FALSEnow honored viassl_aware_get; configcertificate_checknot; the calls still do not honor configcertificate_check: falsefrom config.json, because noparamsis passed - Add tests for ex.
KEEPER_SSL_CERT_FILE=/path/to/custom-ca.pemreturning that path viaparams.ssl_verify
…t(..., verify=params.ssl_verify)
GraphSync connection SSL wiring belongs in the keeper-dag repo and will sync into Commander via copy_to_commander.py after both PRs merge. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
Both points are addressed in the latest push - thanks for flagging them. PAM SaaS: The catalog/plugin downloads were going through ssl_aware_get, which only looked at env vars and never saw params, so certificate_check: false from config.json was ignored. Those calls now use params.ssl_verify instead, same as the rest of Commander - so they pick up KEEPER_SSL_CERT_FILE, config, and legacy VERIFY_SSL. Tests: Added a test that a custom KEEPER_SSL_CERT_FILE PEM path comes back through params.ssl_verify, plus a small fix so VERIFY_SSL=false from other tests doesn't leak into this suite. GraphSync (keeper-dag) is intentionally out of this PR and will follow in that repo after Commander changes are merged. |
sk-keeper
approved these changes
Jul 1, 2026
idimov-keeper
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
VERIFY_SSL: Legacy on/off env var — FALSE disables SSL checking; no custom CA path.
params.ssl_verify: Cached HTTP SSL setting from KEEPER_SSL_CERT_FILE, config, or VERIFY_SSL=FALSE — returns False or a CA file path.