Fix import command/only update if same folder#2176
Open
lthievenaz-keeper wants to merge 3 commits into
Open
Conversation
Added folder match logic to --update flag to avoid undesirable updates / shortcuts.
The partial hash map we used to create would merge similar records:
preexisting_partial_record_hash = {
hash : uid <-- but this could be multiple overlapping records
}
Changed it so that it takes into account different matching records by location:
preexisting_partial_record_hash = {
hash : [
{ uid: uid, folders: [folders] }
]
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider this CSV:
,Administrator,administrator,pass123,,,INFRAWhich imports this content:
I wish to run an import that updates this record + adds another administrator login in a different path:
,Administrator,administrator,pass456,,,INFRA,Administrator,administrator,pass789,,,DEVSo I run:
import --format csv --update my_csv.csvHowever this causes the following problems:
pass789)This commit introduces change to the import process so that: