KC-1330 bugfix: Launch/Admin credential don't stick after pam connection edit#2181
Open
Conversation
…admin missing when admin and launch are the same pamUser Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes KC-1330:
pam connection editnow attaches admin and launch credentials on the first run whenconfigure_resourceis used.After krouter sets credential flags, the local
link_user()follow-up was writing only{ belongs_to: true }, which clobberedis_launch_credentialon the launch user's ACL edge. When admin and launch are the same pamUser,is_adminwas also lost.The follow-up now preserves krouter flags:
belongs_to+is_launch_credentialon the launch edgeis_adminwhenadmin_uid == launch_uidRoot cause
TunnelDAG.set_launch_credentials()uses a two-step flow:configure_resourcewithconnectUsersand optionaladminUidlink_user()+ DAGsave()on the launch user's ACL edgeIssue 1 (different users): follow-up overwrote the edge without
is_launch_credential.Issue 2 (same user): krouter does not set
is_adminwhen the user is inconnectUsers; the follow-up must preserve it locally.