Fix pam rotation edit --schedule-config and scripts_only setup (KC-1331)#2182
Open
idimov-keeper wants to merge 2 commits into
Open
Conversation
idimov-keeper
commented
Jul 1, 2026
Contributor
- Wire --schedule-config (-sf) through all pam rotation edit code paths (general, IAM, SaaS, schedule-only) via shared schedule resolution helpers, matching Web Vault “use default rotation schedule” behavior.
- Add a dedicated scripts_only rotation setup path with config-rooted noop DAG linking and server-assigned rotation revision handling (fixes Resource "None" and invalid revision errors).
- Sync vault at command start when -sf is used so defaultRotationSchedule is read from a current PAM configuration record (fixes on-demand → config-default transitions without manual sync-down).
Honor --schedule-config across rotation profiles, add a dedicated scripts_only path with correct noop DAG linking and rotation revision handling, and sync vault before --schedule-config so PAM config defaultRotationSchedule is current. Co-authored-by: Cursor <cursoragent@cursor.com>
Expose Web Vault default-schedule state by comparing stored rotation schedule JSON to the PAM configuration defaultRotationSchedule field. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.