KC-1337: Fix iam_user rotation schedule not applied on initial create#2183
Conversation
Sync rotation revision after IAM link permission-check so the schedule-bearing set_record_rotation call uses the server revision instead of 0. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pam rotation edit --rotation-profile iam_userso a cron/--schedulejsonschedule is applied on first setup instead of failing withrevision 0 less than 1.link_user_to_configruns its IAM permission-checkset_record_rotation(which creates rotation at revision 1 without a schedule), sync vault and use the server revision for the follow-up request that carries the schedule.resolve_record_rotation_revisionand the iam_user initial-create / already-linked paths.