Reporting command implementation(Audit, Action and Password).#194
Open
ukumar-ks wants to merge 3 commits into
Open
Reporting command implementation(Audit, Action and Password).#194ukumar-ks wants to merge 3 commits into
ukumar-ks wants to merge 3 commits into
Conversation
ukumar-ks
requested review from
THeflinKeeper,
saldoukhov and
tylerccarson
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tylerccarson
reviewed
Jul 1, 2026
| payload.created = createdCriteria(filter.created) | ||
| } | ||
| } | ||
| if (filter.eventType !== undefined) payload.event_type = filter.eventType |
Contributor
There was a problem hiding this comment.
Apparently this should be audit_event_type, or else you'll get a validation error.
The example in the docs support this: https://keeper.atlassian.net/wiki/spaces/KA/pages/765952090/Filter+examples
| exclude_min?: boolean | ||
| exclude_max?: boolean | ||
| } | ||
| event_type?: string | number | Array<string | number> |
Contributor
There was a problem hiding this comment.
as mentioned earlier, should be audit_event_type
tylerccarson
reviewed
Jul 1, 2026
| exclude_min?: boolean | ||
| exclude_max?: boolean | ||
| } | ||
| event_type?: string | number | Array<string | number> |
Contributor
There was a problem hiding this comment.
should drop this then too
ukumar-ks
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds SDK reporting commands for Audit, Action, and Password reports.
Changes