BE-7755: preserve platform-connect side-effects in sideEffects allowlist#196
Merged
svelichkin-keeper merged 1 commit intoJul 1, 2026
Merged
Conversation
5b50ed1 to
2d23229
Compare
tylerccarson
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BE-7755
Summary
The
sideEffectsallowlist (["**/configureProtobuf*"]) was scoped to let downstream bundlers tree-shakeproto.js. A consequence is that every module not listed is treated as side-effect-free — including the entry modules that callconnectPlatform(...). Downstream bundlers (e.g. webpack) then drop that call, the module-levelplatformbinding is never initialized, and a consumer that imports named exports and runs crypto in a separate bundle/realm — such as an MV3 offscreen document — seesplatformasundefinedat runtime and crypto fails.How
sideEffectsbehavesconnectPlatformalways runs.false: every module is treated as pure, so all side-effect-only imports are eligible for removal.[globs](current): only the listed files may have side effects; everything else is treated as pure. TheconfigureProtobuf*allowlist unintentionally excluded theconnectPlatformentry modules.This PR adds the browser entry modules to the allowlist, so bundlers preserve the platform connection while still tree-shaking
proto.js:dist/browser/index.js—connectPlatform(browserPlatform)dist/worker/browserWorker.js— browser worker entryThe change is additive metadata only: it makes consuming bundlers more conservative and cannot alter runtime behavior for consumers that were already working.