enterprise-team membership user/role ops#206
Open
mtyagi-ks wants to merge 2 commits into
Open
Conversation
adeshmukh-ks
reviewed
Jul 2, 2026
| parser.add_argument('-ru', '--remove-user', action='append', help='remove user from team. @all') | ||
| parser.add_argument('-ar', '--add-role', action='append', help='add user to team') | ||
| parser.add_argument('-rr', '--remove-role', action='append', help='remove user from team, @all') | ||
| parser.add_argument('-ar', '--add-role', action='append', help='add role to team') |
Contributor
There was a problem hiding this comment.
these changes shoud be supported in team add and edit commands, replicate these supports in team add and team edit subcommands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves
enterprise-team membershipuser and role add/remove operations to match Commander behavior and fixes related SDK batch handling.-hsf/--hide-shared-folderssupport when adding users to a teamTeamUserEdit.user_typein batch processing (was always hardcoded to0)team_enterprise_user_updatewhen updating hide-shared-folders for existing team members-au,-ru,-ar, or-rr-ar/-rrrole flagsuser_typemapping with Commander (on→ 2,off→ 1) inenterprise-userandenterprise_user_managementteam_user_type_from_hsf_flag(),team_user_type_from_hide_shared_folders(),RoleUtils.is_admin_role()Test plan
enterprise-downthenenterprise-team add "Developers"enterprise-team membership "Developers" -au <email>— user appears inenterprise-team viewenterprise-team membership "Developers" -ar "PAM Workflow Admin"— role linked to teamenterprise-team membership "Developers" -ru <email>— user removedenterprise-team membership "Developers" -rr "PAM Workflow Admin"— role removedenterprise-team membership "Developers" -ru @all/-rr @all— bulk remove worksenterprise-team membership "Developers" -ar "Keeper Administrator"— warning, no assignmententerprise-team membership "Developers" -au <email> -hsf on— hide-shared-folders applied-hsf offon existing member — updates viateam_enterprise_user_updateenterprise-team membership "Developers"with no flags — clear error message