Close #21: Fix strides calculation in vxMapTensorPatch#22
Conversation
|
|
Review: Tensor Stride Calculation FixProblem: The stride calculation was using view_end[i] - view_start[i] when computing stride for dimension i, but it should reference the previous dimension size (i-1) since strides accumulate from lower dimensions. Fix: Using view_end[i - 1] - view_start[i - 1] correctly computes the size of the previous dimension for stride calculation. Assessment: Looks correct - This appears to be a legitimate bug fix. The logic makes sense: stride[i] = stride[i-1] multiplied by (size of dimension i-1). Has this been tested with multi-dimensional tensors? Would be good to verify with actual test cases before merging since it has been open since 2020. |
No description provided.