refactor(sonar): fix remaining sonar issues

[ReenigneArcher]

Description

Should fix remaining sonar issues.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

• feat: New feature (non-breaking change which adds functionality)
• fix: Bug fix (non-breaking change which fixes an issue)
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
• refactor: Code change that neither fixes a bug nor adds a feature
• perf: Code change that improves performance
• test: Adding missing tests or correcting existing tests
• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit
• BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

• Code follows the style guidelines of this project
• Code has been self-reviewed
• Code has been commented, particularly in hard-to-understand areas
• Code docstring/documentation-blocks for new or existing methods/components have been added or updated
• Unit tests have been added or updated for any new or modified functionality

AI Usage

• None: No AI tools were used in creating this PR
• Light: AI provided minor assistance (formatting, simple suggestions)
• Moderate: AI helped with code generation or debugging specific parts
• Heavy: AI generated most or all of the code changes

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

❌ Patch coverage is 87.02290% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.91%. Comparing base (6ecc54e) to head (f6a8706).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/windows/win_api_layer.cpp	75.00%	9 Missing and 6 partials ⚠️
...rc/common/include/display_device/retry_scheduler.h	94.87%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
- Coverage   92.99%   92.91%   -0.09%     
==========================================
  Files          35       35              
  Lines        2328     2357      +29     
  Branches     1119     1116       -3     
==========================================
+ Hits         2165     2190      +25     
- Misses         64       76      +12     
+ Partials       99       91       -8     

Flag	Coverage Δ
Linux	91.89% <89.74%> (-0.80%)	⬇️
Windows-AMD64	91.32% <82.05%> (-0.28%)	⬇️
Windows-ARM64	66.86% <62.01%> (+0.58%)	⬆️
macOS	74.02% <75.51%> (+1.46%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/common/include/display_device/logging.h	100.00% <100.00%> (ø)
src/common/logging.cpp	93.58% <100.00%> (+0.43%)	⬆️
src/common/types.cpp	100.00% <100.00%> (ø)
src/windows/include/display_device/windows/types.h	91.17% <ø> (ø)
src/windows/persistent_state.cpp	97.82% <100.00%> (+0.09%)	⬆️
src/windows/settings_manager_general.cpp	100.00% <100.00%> (ø)
src/windows/win_api_utils.cpp	99.62% <100.00%> (+<0.01%)	⬆️
src/windows/win_display_device_primary.cpp	100.00% <100.00%> (ø)
...rc/common/include/display_device/retry_scheduler.h	96.12% <94.87%> (-1.29%)	⬇️
src/windows/win_api_layer.cpp	75.34% <75.00%> (-0.07%)	⬇️

... and 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ecc54e...f6a8706. Read the comment docs.