refactor(sonar): reduce code duplication#268
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #268 +/- ##
=======================================
Coverage 92.91% 92.91%
=======================================
Files 35 35
Lines 2357 2357
Branches 1116 1115 -1
=======================================
Hits 2190 2190
+ Misses 76 50 -26
- Partials 91 117 +26
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
|
ReenigneArcher
force-pushed
the
refactor/sonar/reduce-code-duplication
branch
from
b836fc4 to
440d427
Compare
Move and simplify several test helper functions out of the test fixture, change primary-device helper to accept std::string_view, and add a makePamWithSharedMode helper. Add missing includes (<string_view> and <format>) and replace string concatenation with std::format for friend/display names. Use 'using enum display_device::HdrState' to shorten enum usages and update related expectations. Also mark expectedFallbackTopologyEvaluationCalls as const and adjust some local variable types to match the new helpers.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove code duplication reported by sonar.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage