Skip to content

Fix .silol.series generation #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wilfonba wants to merge 3 commits into
base: master
Choose a base branch
from
+4 −4
Draft

Fix .silol.series generation #1591

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a15d799
reorder .silo.series creation
wilfonba Jun 13, 2026
454d7f6
Merge branch 'master' into IOFix
sbryngelson Jun 15, 2026
e4318dc
Merge branch 'master' into IOFix
sbryngelson Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions toolchain/templates/include/helpers.mako
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ END

t_${target.name}_stop=$(python3 -c 'import time; print(time.time())')

% if target.name == 'post_process':
python3 "${MFC_ROOT_DIR}/toolchain/templates/include/generate_silo_series.py" '${os.path.dirname(input)}'

@sbryngelson sbryngelson Jun 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: this now runs unconditionally (for post_process) even when post_process actually failed — i.e. it may execute generate_silo_series.py over missing or partial silo output. Since code is already captured above, it won't mask the real error, but worth confirming generate_silo_series.py degrades gracefully (no silo files / incomplete set) rather than dumping a traceback. If you'd rather only generate on success, gating this on [ $code -eq 0 ] would do it — though I suspect you want it to run on the spurious-failure case, which is the whole point of the PR.

@wilfonba wilfonba Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generate_silo_series.py reads the list of files present in the root directory when it is called, so it should never fail if files exist in the root directory. I don't know what it would do if there were no files in the root directory. I'll have to check the actual script when I'm on the right computer.

% endif
Comment thread
wilfonba marked this conversation as resolved.

if [ $code -eq 22 ]; then
echo
error "$YELLOW CASE FILE ERROR$COLOR_RESET > $YELLOW Case file has prohibited conditions as stated above.$COLOR_RESET"
Expand All @@ -99,10 +103,6 @@ END
exit 1
fi

% if target.name == 'post_process':
python3 "${MFC_ROOT_DIR}/toolchain/templates/include/generate_silo_series.py" '${os.path.dirname(input)}'
% endif

% if output_summary:

cd '${MFC_ROOT_DIR}'
Expand Down
Loading