📖 [Docs]: Fill gaps in coding standards#53
Merged
Marius Storhaug (MariusStorhaug) merged 1 commit intoJul 18, 2026
Conversation
Marius Storhaug (MariusStorhaug)
deleted the
docs/fill-coding-standards-gaps
branch
July 18, 2026 14:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds only the guidance that was missing after comparing the candidate standards from PSModule/docs PR #61 against the existing canonical MSXOrg/docs coding standards.
Topic-by-topic comparison
GitHub Actions
Already covered in
src/docs/Coding-Standards/GitHub-Actions.md:permissionsvarsvssecretsenv:Missing and added:
actions/checkoutshould usepersist-credentials: falseunless a job intentionally pushespull_request_targetandworkflow_runshould be avoided unless the elevated context is required, and privileged work must not execute untrusted codePowerShell
Already covered in
src/docs/Coding-Standards/PowerShell/:#Requires -Modulesand version constraintsMissing and added:
-Verbose/-Debugforwarding to internal calls[Environment]::GetEnvironmentVariable()when the provider is not the pointValidation
pwsh .github/scripts/Update-DocumentationIndex.ps1 -Checkpwsh .github/scripts/Test-DocumentationLink.ps1