MDEV-38369 Windows - improve heap allocation performance with segmentHeap#5220
MDEV-38369 Windows - improve heap allocation performance with segmentHeap#5220vaintroub wants to merge 1 commit into
Conversation
vaintroub
changed the title
There was a problem hiding this comment.
Pull request overview
This PR opts MariaDB Windows executables into using the modern Windows Segment Heap via the application manifest, targeting improved heap allocation scalability under concurrent workloads.
Changes:
- Add
heapType=SegmentHeapto the Windows compatibility manifest to enable Segment Heap.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Windows compatibility manifest (cmake/win_compatibility.manifest) to enable the SegmentHeap heap type, which can improve memory efficiency on supported Windows versions. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…tHeap Use modern segmentHeap heap manager on Windows. The problem it is solving is severily reduced scalability on concurrent OLTP benchmarks, due to inherent scalability problems in default NT Heap implementation. The benchmarks (see the corresponding ticket) show improvements across the board, with about 5-10% on low concurrency up to several orders of magnitude on high concurrency. Also addressed Gemini and Copilot concerns about correct namespace in the app manifest XML file - make it the same as in Microsoft examples.
Use modern segmentHeap heap manager on Windows.
The problem it is solving is severily reduced scalability on concurrent OLTP benchmarks, due to inherent scalability problems in default NT Heap implementation.
The benchmarks (see the corresponding ticket) show improvements across the board, with about 5-10% on low concurrency up to several orders of magnitude on high concurrency.