MDEV-29909 : SST fails when table is defined with DATA DIRECTORY='/pa…#5226
Open
janlindstrom wants to merge 1 commit into
Open
MDEV-29909 : SST fails when table is defined with DATA DIRECTORY='/pa…#5226janlindstrom wants to merge 1 commit into
janlindstrom wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the use of std::filesystem::space with statvfs to determine the available space on the target filesystem. A review comment points out that f_frsize can be 0 on some systems, which would incorrectly result in available space being calculated as 0 and causing the SST to fail; it suggests falling back to f_bsize in such cases.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Contributor
Author
…th/to' and datafile is larger than datadir space std::filesystem is not available in all supported environments. Replaced by using statvfs if available. If not available return error and SST will fail.
janlindstrom
force-pushed
the
13.1-MDEV-29909-fix
branch
from
88372d7 to
e113e47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…th/to' and datafile is larger than datadir space
std::filesystem is not available in all supported environments. Replaced by using statvfs if available. If not available return error and SST will fail.