implement file server as a config flag#2419
Open
Bud-Macaulay wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
seems that the server config was leaking between tests - i presume due to some side effect when importing create_app. i have (hopefully) fixed this by isolating the tests i wrote in class fixtures |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2419 +/- ##
==========================================
+ Coverage 90.32% 90.36% +0.04%
==========================================
Files 78 78
Lines 5086 5108 +22
==========================================
+ Hits 4594 4616 +22
Misses 492 492
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
e7e0094 to
e9ea7bb
Compare
e9ea7bb to
01dba5f
Compare
Contributor
Author
|
Fixes #2417 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems to work in the limited testing.
Implements a new
StaticFilesConfigentity and passes it into the ServerConfig.I'm not sold on the naming conventions or the defaults. Perhaps could do with some language/docstrings for clarity aswell.
Happy to discuss