Skip to content

implement file server as a config flag#2419

Open
Bud-Macaulay wants to merge 2 commits into
Materials-Consortia:mainfrom
Bud-Macaulay:impl-file-server
Open

implement file server as a config flag#2419
Bud-Macaulay wants to merge 2 commits into
Materials-Consortia:mainfrom
Bud-Macaulay:impl-file-server

Conversation

@Bud-Macaulay

Copy link
Copy Markdown
Contributor

Seems to work in the limited testing.

Implements a new StaticFilesConfig entity and passes it into the ServerConfig.

I'm not sold on the naming conventions or the defaults. Perhaps could do with some language/docstrings for clarity aswell.

Happy to discuss

@Bud-Macaulay Bud-Macaulay marked this pull request as draft July 2, 2026 07:11
@Bud-Macaulay

Copy link
Copy Markdown
Contributor Author

seems that the server config was leaking between tests - i presume due to some side effect when importing create_app. i have (hopefully) fixed this by isolating the tests i wrote in class fixtures

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.36%. Comparing base (d8b22c0) to head (01dba5f).

Files with missing lines Patch % Lines
optimade/server/config.py 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2419      +/-   ##
==========================================
+ Coverage   90.32%   90.36%   +0.04%     
==========================================
  Files          78       78              
  Lines        5086     5108      +22     
==========================================
+ Hits         4594     4616      +22     
  Misses        492      492              
Flag Coverage Δ
project 90.36% <90.90%> (+0.04%) ⬆️
validator 90.36% <90.90%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Bud-Macaulay

Copy link
Copy Markdown
Contributor Author

Fixes #2417

@Bud-Macaulay Bud-Macaulay marked this pull request as ready for review July 2, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant