Skip to content

Stabilize TradingView indicator CI tests#317

Merged
Mathieu2301 merged 1 commit into
mainfrom
fix/stabilize-tradingview-ci
Jun 23, 2026
Merged

Stabilize TradingView indicator CI tests#317
Mathieu2301 merged 1 commit into
mainfrom
fix/stabilize-tradingview-ci

Conversation

@Mathieu2301

Copy link
Copy Markdown
Owner

Summary

  • Serialize the Node matrix jobs with max-parallel: 1 because the authenticated TradingView tests share the same session secrets.
  • Give the MarketCipher B websocket study test the same 30s timeout as the SuperTrend strategy test.
  • Wait for actual MarketCipher values before resolving the test promise.

Context

The post-merge Actions run for #316 no longer failed on SuperTrend. Node 14.x and 18.x timed out on Indicators > gets data from MarketCipher B study, while Node 19.x passed. That points to external TradingView websocket/session flakiness under concurrent matrix jobs rather than a deterministic code regression.

GitHub also reported a high vite Dependabot alert via vitest. npm audit proposes vitest@4.1.9, but that requires Node 20+, while this repo currently tests Node 14/18/19. I intentionally did not force that upgrade in this PR.

Validation

  • npm test -- --run50 passed | 16 skipped

Signed-off-by: Nox nox@molted.net

Signed-off-by: Nox <nox@molted.net>
@Mathieu2301 Mathieu2301 merged commit 5baea86 into main Jun 23, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant