perf: rewrite expected_event internals using vectors#641
Closed
yihui wants to merge 1 commit into
Closed
Conversation
…frames The original expected_event used data.frame(), merge(), and multiple order() calls for computation on small interval tables. Profiling showed expected_event accounted for 65% of pw_info time, and data.frame overhead was 35% of expected_event time. Rewrite using pure vector operations: compute the union of enrollment and failure breakpoints directly, use stepfun2 for rate lookups, and perform all arithmetic on plain numeric vectors. Only construct a data.frame for the final output when simple=FALSE. This yields an 8x speedup for expected_event (3.6ms -> 0.43ms per call) and ~2.5x speedup for pw_info. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
Collaborator
Author
|
Closing due to concerns about potential breakage (a huge amount of effort has been made on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expected_event()internals using pure vector arithmetic instead of data.frame/merge/order operationsstats::stepfun()withstepfun2()(already on main) for rate lookupspw_infoSplit from #623 to keep the
expected_event.Roptimization reviewable independently.Key changes
simple = FALSETest plan
test-developer-expected_event.Rpassestest-independent-expected_event.Rpasses🤖 Generated with Claude Code