Suppress focus halo on icon action buttons after mouse click#638
Open
harminius wants to merge 1 commit into
Open
Suppress focus halo on icon action buttons after mouse click#638harminius wants to merge 1 commit into
harminius wants to merge 1 commit into
Conversation
QA reported the resend / trash buttons on invitation rows keep the focus halo after a mouse click. Add a :focus:not(:focus-visible) rule to .icon-action-btn so the ring is dropped on mouse interaction but preserved for keyboard navigation (accessibility).
Coverage Report for CI Build 27401029854Coverage remained the same at 92.156%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a one-line CSS rule on `.icon-action-btn` to drop the focus ring on mouse interaction while preserving it for keyboard navigation (accessibility).