Skip to content

fix(transaction-pay-controller): block raw publish without Pay quote#9101

Draft
matthewwalsh0 wants to merge 2 commits into
mainfrom
fix/pay-publish-hook-explicit-config-guard
Draft

fix(transaction-pay-controller): block raw publish without Pay quote#9101
matthewwalsh0 wants to merge 2 commits into
mainfrom
fix/pay-publish-hook-explicit-config-guard

Conversation

@matthewwalsh0

Copy link
Copy Markdown
Member

Explanation

TransactionPayPublishHook previously returned an empty hook result whenever a transaction had no Pay quotes. That is still useful for transactions the Pay controller is only observing, but unsafe once a transaction has explicit Pay configuration because TransactionController can continue through its normal raw-publish fallback.

This PR makes empty quotes fail closed for transactions with explicit Pay configuration, while preserving the existing fallthrough behavior for unmanaged transactions with no quote state.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate\n- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate\n- [x] I've communicated my changes to consumers by updating changelogs for packages I've changed\n- [ ] I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant