fix(transaction-pay-controller): block raw publish without Pay quote#9101
Draft
matthewwalsh0 wants to merge 2 commits into
Draft
fix(transaction-pay-controller): block raw publish without Pay quote#9101matthewwalsh0 wants to merge 2 commits into
matthewwalsh0 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
TransactionPayPublishHookpreviously returned an empty hook result whenever a transaction had no Pay quotes. That is still useful for transactions the Pay controller is only observing, but unsafe once a transaction has explicit Pay configuration becauseTransactionControllercan continue through its normal raw-publish fallback.This PR makes empty quotes fail closed for transactions with explicit Pay configuration, while preserving the existing fallthrough behavior for unmanaged transactions with no quote state.
References
Checklist