Skip to content

chore(ci): make quality checks non-mutating - #176

Merged
TheRealAgentK merged 2 commits into
mainfrom
chore/ci-non-mutating-checks
Jul 22, 2026
Merged

chore(ci): make quality checks non-mutating#176
TheRealAgentK merged 2 commits into
mainfrom
chore/ci-non-mutating-checks

Conversation

@TheRealAgentK

Copy link
Copy Markdown
Contributor

Summary

  • make JavaScript and TypeScript lint scripts check-only in CI
  • retain explicit eslint:fix and tseslint:fix commands for local remediation
  • replace the third-party write-mode Prettier action with the repository-pinned Prettier check
  • remove the Prettier job's dependency on PERSONAL_GITHUB_TOKEN

This prevents lint jobs from silently rewriting files while reporting success and makes formatting checks deterministic from package-lock.json.

Validation

  • npm ci / TypeScript compilation
  • npm test — 13/13 passing
  • npm run eslint
  • npm run tseslint
  • npm exec -- prettier --check "lib/*.ts" "test/*.js" "example/*.js"

The existing dependency audit findings are deliberately unchanged and will be addressed in the next consolidated dependency/security PR.

@TheRealAgentK
TheRealAgentK requested review from a team, Olwiba, phillip-haydon, sumitramanga and velocitysystems and removed request for a team July 21, 2026 22:59

@Olwiba Olwiba left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

Comment thread .github/workflows/node.js.yml Outdated
@TheRealAgentK
TheRealAgentK merged commit 369fb58 into main Jul 22, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants