feat: user api integration + sign in / sign up flow fix by Alessandro100 · Pull Request #145 · MobilityData/mobilitydatabase-web

Alessandro100 · 2026-06-04T19:28:33Z

closes #139

Summary:

Integrates the new user-service api
Consolidates the sign up / sign in logic into a shared component
New e2e tests (mainly for sign up / sign flow)
Ability to edit user profile

Expected behavior:

When signing up or logging in from the 'notification' subscription button or the 'contribute' page, you should be take through the entire flow of log in before going back to the intended page
You should be able to edit your profile
The user data will now come from the user-service api and not firebase

Testing tips:

Login / Signup

Test the login / signup flow from the add feed form, or the notification button (oauth and email / password)

Account

Go on your account profile and edit your account

Follow up tickets

Put a blocker on the notification button and add feed form if the user's email is not verified
Revisit the route guards for verify-email and complete-registration
Touch up the styling of the sign in / sign up / complete-registration page (basic)
Be able to generate the user-service types from artifacts (like we do with feeds api)
Add the "plugin:react-hooks/recommended" eslint rule

Please make sure these boxes are checked before submitting your pull request - thanks!

Run the unit tests with yarn test to make sure you didn't break anything
Add or update any needed documentation to the repo
Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
Linked all relevant issues
Include screenshot(s) showing how this pull request works and fixes the issue(s)

vercel · 2026-06-04T19:28:39Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
mobilitydatabase-web	Ready	Preview, Comment	Jun 5, 2026 12:52pm

Copilot

Pull request overview

custom: Applied vercel-react-best-practices.

This PR migrates user profile data from Firebase callables to the new user-service REST API, centralizes post-auth redirect logic across sign-in/sign-up/verify-email/complete-registration screens, and adds UI + E2E coverage for editing user profiles and the full registration flow.

Changes:

Add user-service OpenAPI schema + generated types and integrate /v1/user GET/PUT into the profile service.
Introduce a shared useRegistrationFlowRedirect hook and update auth/registration pages to use it.
Add account profile editing (save flow + UI loading/toast feedback) and expand Cypress E2E coverage for sign-in, sign-up flow, and account editing.

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/app/types.ts	Adds action type constant for saving user profile.
src/app/store/saga/profile-saga.ts	Adds saga to persist profile edits via the user-service API.
src/app/store/saga/auth-saga.ts	Enhances sign-up flow to fetch user-service profile data after Firebase sign-up.
src/app/store/profile-selectors.ts	Adds selector for save-user-profile status.
src/app/store/profile-reducer.ts	Adds reducers/state for profile save lifecycle (loading/success/fail/reset).
src/app/services/user-service-api-types.ts	Adds generated OpenAPI types for the user-service API.
src/app/services/profile-service.ts	Replaces Firebase callable profile read/write with `/v1/user` GET/PUT.
src/app/hooks/useRegistrationFlowRedirect.ts	New centralized redirect logic for the multi-step registration flow.
src/app/hooks/index.ts	Re-exports the new registration redirect hook.
src/app/[locale]/verify-email/PostRegistration.tsx	Uses the new redirect hook instead of per-page redirect effect.
src/app/[locale]/verify-email/page.tsx	Temporarily removes auth/status wrapper around verify-email page.
src/app/[locale]/sign-up/SignUp.tsx	Uses shared redirect hook; removes duplicated redirect effect.
src/app/[locale]/sign-in/SignIn.tsx	Uses shared redirect hook; removes duplicated redirect effect.
src/app/[locale]/complete-registration/page.tsx	Temporarily removes auth/status wrapper around complete-registration page.
src/app/[locale]/complete-registration/CompleteRegistration.tsx	Uses shared redirect hook; removes duplicated redirect effect.
src/app/[locale]/account/AccountSectionContainer.tsx	Adds optional loading indicator to account section container.
src/app/[locale]/account/AccountGeneral.tsx	Adds profile edit/save UI, status toasts, and dispatches save actions.
package.json	Adds scripts to generate user-service API types from OpenAPI YAML.
external_types/UserServiceAPI.yaml	Adds user-service OpenAPI spec (profile + notifications/subscriptions).
external_types/BearerTokenSchema.yaml	Adds shared bearer auth schema referenced by the user-service spec.
cypress/support/index.ts	Declares new Cypress command for Firebase-only user creation.
cypress/support/commands.ts	Implements `createNewFirebaseUser` helper for E2E flows controlling Redux directly.
cypress/e2e/signup.cy.ts	Adds E2E coverage for full verify-email → complete-registration → redirect flow.
cypress/e2e/signin.cy.ts	Adds E2E coverage for post-login redirect behaviors.
cypress/e2e/accountGeneral.cy.ts	Adds E2E coverage for account profile editing and error flows.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

github-actions · 2026-06-05T13:02:22Z

*Lighthouse ran on https://mobilitydatabase-330zywy8m-mobility-data.vercel.app/ * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟠 83	🟢 94	🟢 96	🟢 100

*Lighthouse ran on https://mobilitydatabase-330zywy8m-mobility-data.vercel.app/feeds * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟠 82	🟠 87	🟢 96	🟢 100

*Lighthouse ran on https://mobilitydatabase-330zywy8m-mobility-data.vercel.app/feeds/gtfs/mdb-2126 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🔴 35	🟢 94	🟢 96	🟢 100

*Lighthouse ran on https://mobilitydatabase-330zywy8m-mobility-data.vercel.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟠 87	🟠 84	🟢 96	🟢 100

*Lighthouse ran on https://mobilitydatabase-330zywy8m-mobility-data.vercel.app/feeds/gbfs/gbfs-flamingo_porirua * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟠 74	🟢 94	🟢 96	🟢 100

davidgamez · 2026-06-05T15:26:02Z

              sx={{ mt: 1 }}
            >
-              Change Password
+              {t('changePassword')}


davidgamez

LGTM!
I'll leave it to @emmambd to review the UX flow

davidgamez · 2026-06-05T15:26:52Z

-      <ProtectedPageWrapper targetStatus='unverified'>
-        <PostRegistration />
-      </ProtectedPageWrapper>
+      {/* TODO: Revisit protected page wrappers. This page changes the status of the user which causes flickers of mismatched authentication */}


👍 Let's create an issue to be able to follow-up

emmambd · 2026-06-05T15:51:39Z

Tested subscribing to notifications and going to the contribute page signed out - both flows worked.

I could edit my name, my organization, and my email consent without issue. LGTM!

Alessandro100 added 8 commits June 3, 2026 13:26

integration of the user-service api

1ca4c97

centralizing the auth flow logic

023d4d4

disabled page protection on verify-email and complete-registration

335df0f

types of the new API

dd0596f

user service api integration

a4945e5

ability to edit user profile

b7eebea

updated suite of e2e tests

3c0f9c4

scripts to generate types

25e9986

Alessandro100 requested a review from Copilot June 4, 2026 19:28

Copilot started reviewing on behalf of Alessandro100 June 4, 2026 19:28 View session

Copilot AI reviewed Jun 4, 2026

View reviewed changes

lint fix

b99148d

vercel Bot deployed to Preview June 4, 2026 19:38 View deployment

Potential fix for pull request finding

2612312

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

vercel Bot deployed to Preview June 4, 2026 19:40 View deployment

Potential fix for pull request finding

f4e7a69

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

vercel Bot deployed to Preview June 4, 2026 19:43 View deployment

account general localization

a8f56b2

vercel Bot deployed to Preview June 4, 2026 19:45 View deployment

Alessandro100 added 2 commits June 5, 2026 08:50

sign-in support for oauth providers

b64058d

disabled changepassword tests

5f4d3e5

vercel Bot deployed to Preview June 5, 2026 12:52 View deployment

davidgamez reviewed Jun 5, 2026

View reviewed changes

davidgamez approved these changes Jun 5, 2026

View reviewed changes

Alessandro100 merged commit d408ed9 into main Jun 9, 2026
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: user api integration + sign in / sign up flow fix#145

feat: user api integration + sign in / sign up flow fix#145
Alessandro100 merged 14 commits into
mainfrom
feat/139-user-api-integration

Alessandro100 commented Jun 4, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Jun 4, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 5, 2026

Uh oh!

davidgamez Jun 5, 2026

Uh oh!

davidgamez left a comment

Uh oh!

davidgamez Jun 5, 2026

Uh oh!

emmambd commented Jun 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Alessandro100 commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 5, 2026

Uh oh!

davidgamez Jun 5, 2026

Choose a reason for hiding this comment

Uh oh!

davidgamez left a comment

Choose a reason for hiding this comment

Uh oh!

davidgamez Jun 5, 2026

Choose a reason for hiding this comment

Uh oh!

emmambd commented Jun 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Alessandro100 commented Jun 4, 2026 •

edited

Loading

vercel Bot commented Jun 4, 2026 •

edited

Loading