DEV-1565 поддержка Global Catalog#147
Open
a-trofimov wants to merge 1 commit into
Open
Conversation
KotikovAlexander
requested changes
Jul 17, 2026
| /// Нужен при поиске через Global Catalog, где sAMAccountName формально уникален | ||
| /// только в рамках домена (не леса). | ||
| /// </summary> | ||
| IReadOnlyList<ILdapProfile> ExecuteMany(FindUserDto request); |
Collaborator
There was a problem hiding this comment.
Не надо так
Пиши тонкие порты
Выделим отдельный интерфейс
| /// Нужен, чтобы явно указанный пользователем домен в DOMAIN\user не терялся при поиске | ||
| /// через Global Catalog. Возвращает null, если сопоставление не найдено. | ||
| /// </summary> | ||
| string? ResolveDomainDnsNameByNetBiosName( |
Collaborator
There was a problem hiding this comment.
не имеет отношение к интерфейсу
Скорее к UserIdentity
| return null; | ||
| } | ||
|
|
||
| var globalCatalogConnectionString = new LdapConnectionString(context.LdapConfiguration.ConnectionString); |
Collaborator
There was a problem hiding this comment.
LdapConnectionString
Инфра просачивается в application
| List<LdapAttributeName> attributes, | ||
| RadiusPipelineContext context) | ||
| { | ||
| var stopwatch = Stopwatch.StartNew(); |
Collaborator
There was a problem hiding this comment.
Подозреваю что это нужно в инфре
| ArgumentNullException.ThrowIfNull(globalCatalogConnectionString); | ||
| ArgumentException.ThrowIfNullOrWhiteSpace(domainDnsName); | ||
|
|
||
| var isSsl = globalCatalogConnectionString.Port == GlobalCatalogSslPort |
Collaborator
There was a problem hiding this comment.
кажется это функционал для ldap.core
Collaborator
There was a problem hiding this comment.
Да и почти все остальное
| /// Извлекает DNS-имя домена (например, "child.test.group") из DN пользователя, | ||
| /// найденного через GC (например, "CN=User1,OU=Users,DC=child,DC=test,DC=group"). | ||
| /// </summary> | ||
| public static string ExtractDomainDnsName(this DistinguishedName dn) |
Collaborator
There was a problem hiding this comment.
Кажется что метод не на своем месте
| { | ||
| ArgumentNullException.ThrowIfNull(dn); | ||
|
|
||
| var parts = dn.StringRepresentation |
Collaborator
There was a problem hiding this comment.
лучше dn.Components
| userIdentity.Identity, | ||
| searchBase); | ||
|
|
||
| if (context.LdapConfiguration!.IsGlobalCatalog()) |
Collaborator
There was a problem hiding this comment.
Наверно всё таки этим должна инфра заниматься
application должно быть без разницы GC или Domain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new: