Feature: Certificate passphrase check#238
Open
danopt wants to merge 52 commits into
Open
Conversation
danopt
marked this pull request as draft
August 21, 2023 13:05
danopt
requested review from
martialblog,
mkayontour and
widhalmt
and removed request for
widhalmt
August 31, 2023 11:25
martialblog
reviewed
Aug 31, 2023
martialblog
left a comment
martialblog
left a comment
Member
There was a problem hiding this comment.
Code looks sound.
Just have some questions. Otherwise looks very good.
Member
|
👍 LGTM |
martialblog
previously approved these changes
Sep 25, 2023
danopt
added this pull request to the merge queue
Sep 25, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Sep 25, 2023
danopt
added this pull request to the merge queue
Sep 25, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Sep 25, 2023
widhalmt
added this pull request to the merge queue
Sep 27, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 27, 2023
widhalmt
added this pull request to the merge queue
Sep 28, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 28, 2023
Member
|
Sorry, I totally missed this one: Please add https://github.com/NETWAYS/ansible-collection-elasticstack/blob/feature/crt_passphrase_check/.github/workflows/test_roles_pr.yml#L33 to your GitHub action. Otherwise GitHub will not start mandatory checks while in the Merge Queue. |
…ible-collection-elasticstack into feature/crt_passphrase_check
widhalmt
previously approved these changes
Sep 28, 2023
widhalmt
left a comment
widhalmt
left a comment
Member
There was a problem hiding this comment.
Most steps were already approved and tested. So here's my approve for automated tests in the merge queue.
danopt
enabled auto-merge
September 28, 2023 12:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#42
passphrase_checkpassphrase_checkis set to true, the module will only check if current passphrase is working and returns the result of it, but will not return any information about the certificate