NIAD-3440: Updating documentation links#374
Closed
chiaramapellimt wants to merge 5 commits into
Closed
Conversation
|
Images built and published to ECR using a Build Id of PR-296-198859f |
Jonopono123
reviewed
Mar 31, 2026
| values sent to the adaptor must comply with the GP Links Specification and FHSREG:0:1:FH:FHS001. | ||
|
|
||
| https://digital.nhs.uk/services/nhais/guide-to-nhais-gp-links-documentation | ||
| https://digital.nhs.uk/developer/api-catalogue/nhais-gp-links/guide-to-nhais-gp-links-documentation |
Contributor
There was a problem hiding this comment.
Would it be worth changing these to actual links as below? It should preserve them as clickable links regardless of the preview tool used.
Suggested change
| https://digital.nhs.uk/developer/api-catalogue/nhais-gp-links/guide-to-nhais-gp-links-documentation | |
| [Guide to NHAIS GP links](https://digital.nhs.uk/developer/api-catalogue/nhais-gp-links/guide-to-nhais-gp-links-documentation) |
Collaborator
There was a problem hiding this comment.
This won't work in the description block of an OpenAPI API call block. It will just ignore the markdown tags and show the link directly:
Contributor
There was a problem hiding this comment.
Looks like it works fine on mine, have you tried refreshing the preview?
Jonopono123
reviewed
Mar 31, 2026
| values sent to the adaptor must comply with the GP Links Specification and FHSREG:0:1:FH:FHS001. | ||
|
|
||
| https://digital.nhs.uk/services/nhais/guide-to-nhais-gp-links-documentation | ||
| https://digital.nhs.uk/developer/api-catalogue/nhais-gp-links/guide-to-nhais-gp-links-documentation |
Contributor
There was a problem hiding this comment.
Suggested change
| https://digital.nhs.uk/developer/api-catalogue/nhais-gp-links/guide-to-nhais-gp-links-documentation | |
| [Guide to NHAIS GP links](https://digital.nhs.uk/developer/api-catalogue/nhais-gp-links/guide-to-nhais-gp-links-documentation) |
Jonopono123
reviewed
Mar 31, 2026
| values sent to the adaptor must comply with the GP Links Specification and FHSREG:0:1:FH:FHS001. | ||
|
|
||
| https://digital.nhs.uk/services/nhais/guide-to-nhais-gp-links-documentation | ||
| https://digital.nhs.uk/developer/api-catalogue/nhais-gp-links/guide-to-nhais-gp-links-documentation |
Contributor
There was a problem hiding this comment.
Suggested change
| https://digital.nhs.uk/developer/api-catalogue/nhais-gp-links/guide-to-nhais-gp-links-documentation | |
| [Guide to NHAIS GP links](https://digital.nhs.uk/developer/api-catalogue/nhais-gp-links/guide-to-nhais-gp-links-documentation) |
MartinWheelerMT
requested changes
Mar 31, 2026
MartinWheelerMT
left a comment
MartinWheelerMT
left a comment
Collaborator
There was a problem hiding this comment.
Hangfire on this PR, until I've worked out the implications of changing the system identifer:
"https://digital.nhs.uk/services/nhais/guide-to-nhais-gp-links-documentation"
Jonopono123
reviewed
Mar 31, 2026
| values sent to the adaptor must comply with the GP Links Specification and FHSREG:0:1:FH:FHS001. | ||
|
|
||
| https://digital.nhs.uk/services/nhais/guide-to-nhais-gp-links-documentation | ||
| https://digital.nhs.uk/developer/api-catalogue/nhais-gp-links/guide-to-nhais-gp-links-documentation |
Contributor
There was a problem hiding this comment.
Suggested change
| https://digital.nhs.uk/developer/api-catalogue/nhais-gp-links/guide-to-nhais-gp-links-documentation | |
| [Guide to NHAIS GP links](https://digital.nhs.uk/developer/api-catalogue/nhais-gp-links/guide-to-nhais-gp-links-documentation) |
Contributor
Author
Yep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
We need to change the links to documentation.
Why
Because they moved the docs from new locations, so they were broken.
Type of change
Please delete options that are not relevant.
Checklist: