CCM-18514: Gitleaks Config Improvements#118
Merged
jamesthompson26-nhs merged 1 commit intoJul 9, 2026
Merged
Conversation
m-houston
approved these changes
Jul 9, 2026
sidnhs
approved these changes
Jul 9, 2026
jamesthompson26-nhs
deleted the
feature/CCM-18514_Gitleaks_Config_Improvements
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switches pre-commit gitleaks to run against staged changes ONLY. This was preventing gitleaks checking the local staged changes which is what pre-commit is meant to be checking. CI will still check the whole history in case of history re-writes or naughty people who don't have pre-commit configured.
Updates the shared module tag for pre-commit and all shared actions to use the latest tag (all apart from scan-dependencies) to include more verbose guidance and KOP signposting for dealing with gitleaks.
Also brings the .gitleaksignore and gitleaks.toml into CODEOWNERS so platform must review.
Context
These changes back this new KOP for handling Gitleaks findings:
https://nhsd-confluence.digital.nhs.uk/spaces/RIS/pages/1429674058/PLAT-KOP-020+-+Handling+and+Safely+Ignoring+Gitleaks+False+Positives
This aims to avoid the issues we've seen lately with devs being blocked by other people's work in unmerged branches which should have been caught by pre-commit BEFORE getting into the repo history.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.