CCM-18514: Gitleaks Config Improvements#227
Merged
jamesthompson26-nhs merged 1 commit intoJul 10, 2026
Merged
Conversation
karlmcgi
approved these changes
Jul 10, 2026
chris-elliott-nhsd
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the secret scanning wrapper to support WSL/local Linux shells as well as macOS.
The
scan-secretsaction previously used a BSD-stylescriptinvocation unconditionally when running in an interactive terminal. That worked on macOS, but failed in WSL because GNUscriptexpects the command to be passed via-c. This change adds a small compatibility layer that detects whichscriptvariant is available and uses the correct invocation form.Why
Local pre-commit runs in WSL were failing before
gitleaksactually ran, even though the same check passed in GitHub Actions. CI was unaffected because the action already skips the interactivescriptpath when running in a CI environment.Validation
bash -nType of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.