CCM-21851 missing pack specification

[stevebux]

Description

addresses two unrelated build failures:

• extra validation catching an error in the dev supplier config
• A failure to apply the TLS version when the API gateway is deployed

Context

Type of changes

• Refactoring (non-breaking change)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would change existing functionality)
• Bug fix (non-breaking change which fixes an issue)

Checklist

• I am familiar with the contributing guidelines
• I have followed the code style of the project
• I have added tests to cover my changes
• I have updated the documentation accordingly
• This PR is a result of pair or mob programming

DT3-Specific Checklist

• If I have added a new resource (SQS, Lambda, Gateway, DDB table, etc), I have created the appropriate alarms

---

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

• I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[stevebux]

I went back and looked at the commit that set the Gateway Rest API to TLS1.2, and I had forgotten that the change was more complex than it needed to be, as Terraform didn't support the security_policy and endpoint_access_mode properties on aws_api_gateway_rest_api resources. A fix for that was released a couple of weeks ago, which may explain the change in behaviour. I have therefore reverted the change done under CCM-14114 and reimplemented it in a simple, straightforward manner (i.e. by adding the two properties to aws_api_gateway_rest_api.main

[francisco-videira-nhs]

Looks OK to me