CCM-18536 adding localised devcontainer build#248
Open
aidenvaines-cgi wants to merge 4 commits into
Open
Conversation
sidnhs
reviewed
Jul 8, 2026
| @@ -0,0 +1,18 @@ | |||
| FROM mcr.microsoft.com/devcontainers/ruby:3.3-bookworm | |||
There was a problem hiding this comment.
this base image seems different from all our other repos, do we need to change it everywhere or just here?
sidnhs
previously approved these changes
Jul 8, 2026
jamesthompson26-nhs
previously approved these changes
Jul 8, 2026
aidenvaines-cgi
dismissed stale reviews from jamesthompson26-nhs and sidnhs
via
2c04715
sidnhs
previously approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves build of the devcontainer for codespaces into the repo's GCHR
allows adhoc build of the container too
Context
Currently the devcontainer is built out of the repository-template repo meaning changes to the Gemlock etc need a
make installrunning every time one of the team starts a new codespaceType of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.