Skip to content

BCSS-23563 - feat(ecs-service): add ecs-service module#87

Closed
dave4420 wants to merge 145 commits into
mainfrom
feature/BCSS-23563-add-ecs-service-module
Closed

BCSS-23563 - feat(ecs-service): add ecs-service module#87
dave4420 wants to merge 145 commits into
mainfrom
feature/BCSS-23563-add-ecs-service-module

Conversation

@dave4420

@dave4420 dave4420 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

BCSS-23563

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

DeepikaDK001 and others added 11 commits June 5, 2026 10:37
- Added support for a new RDS module path in dependabot.yaml.
- Created .terraform.lock.hcl for the new RDS module.
- Updated README.md to include usage examples for PostgreSQL and Oracle RDS instances, along with security group and secrets manager integration.
- Modified context.tf to enable module creation based on the 'enabled' variable.
- Introduced locals.tf to define rds_identifier based on provided names.
- Updated main.tf to conditionally create RDS resources based on the 'enabled' variable.
- Enhanced variables.tf to include custom_name variable for explicit RDS instance naming.
- Updated versions.tf to require Terraform version >= 1.13 and AWS provider version >= 6.42.
@dave4420 dave4420 requested review from a team and saliceti as code owners June 22, 2026 12:51
@nhs-oliverslater nhs-oliverslater changed the title feat(ecs-service): add ecs-service module BCSS-23563 - feat(ecs-service): add ecs-service module Jun 23, 2026
dave4420 and others added 27 commits July 9, 2026 11:55
…m:NHSDigital/screening-terraform-modules-aws into feature/BCSS-23563-add-ecs-service-module
…m:NHSDigital/screening-terraform-modules-aws into feature/BCSS-23563-add-ecs-service-module
@nhs-oliverslater nhs-oliverslater marked this pull request as draft July 9, 2026 11:30
@nhs-oliverslater

Copy link
Copy Markdown
Contributor

Github weirdness preventing merging, new PR created: #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants