NPA-7004: Update Status Reason Codes

[davesmallnhs]

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-7004

---

📄 Description/Summary of Changes

Removed from spec:

• APPLICATION_REJECTED_COERCION
• ROLE_DEACTIVATED_FAMILIAL_REASON

Renamed in spec:

• APPLICATION_REJECTED_PROXY_ABROAD (Proxy lives abroad) to APPLICATION_REJECTED_PROXY_NOT_LIVING_IN_ENGLAND_OR_WALES (Proxy not living in England or Wales)
• ROLE_DEACTIVATED_PROXY_ABROAD (Proxy lives abroad) to ROLE_DEACTIVATED_PROXY_NOT_LIVING_IN_ENGLAND_OR_WALES (Proxy not living in England or Wales)

---

🧪 Developer Testing Carried Out

Using make localdev-preview-spec on LOCALDEV, inspected the HTML spec.

Before changes:

• ROLE_DEACTIVATED_FAMILIAL_REASON, APPLICATION_REJECTED_COERCION, ROLE_DEACTIVATED_PROXY_ABROAD and APPLICATION_REJECTED_PROXY_ABROAD all exist in spec

After changes:*

• ROLE_DEACTIVATED_FAMILIAL_REASON and APPLICATION_REJECTED_COERCION have gone away.
• ROLE_DEACTIVATED_PROXY_ABROAD and APPLICATION_REJECTED_PROXY_ABROAD have changed to ENGLAND_OR_WALES

---

📋 PR Principles

• Keep PRs Small and Focused: Ensure the PR addresses a single task or feature to make it easier to review.
• Multiple PRs for one Ticket: When splitting work into multiple PRs, clearly describe what this PR addresses and outline the remaining work to complete the ticket.
• Ensure Tests Are Included: Add or update unit, integration, or end-to-end tests to cover the changes made.
• Follow Coding Standards: Ensure the code adheres to the team's coding guidelines and best practices.
• Resolve Comments Promptly: If you raise a comment, ensure you follow up and resolve it before approving the PR to maintain clarity and ensure comments are addressed.
• Foster Learning: PR reviews are an opportunity to share knowledge, provide constructive feedback, and encourage a collaborative environment.

🏷️ Naming Conventions Reminder

Please ensure the following naming conventions are followed:

• PR title follows the format: NPA-XXXX: <short-description>
• Branch name follows the convention: <type>/NPA-XXXX/<short-description>
• Commit messages follow the template: NPA-XXXX: <short-description>

[github-actions]

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-7004

[Copilot]

Pull request overview

Updates the OpenAPI specification for the consent status reason codes to align with the latest agreed set in NPA-7004.

Changes:

• Removed obsolete reason codes (APPLICATION_REJECTED_COERCION, ROLE_DEACTIVATED_FAMILIAL_REASON) from the documented enum and display list.
• Renamed “proxy abroad” reason codes to “proxy not living in England or Wales” in both enum values and human-readable descriptions.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.