-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(sandbox): honor OCI image working directories #2530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matthewgrossman
wants to merge
16
commits into
main
from
feat/2526-oci-working-dir/matthewgrossman
base: main
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,212
−337
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ec4815f
feat(sandbox): honor OCI image working directories
matthewgrossman 12a79bc
fix(sandbox): harden OCI workspace handling
matthewgrossman 8d90949
fix(ci): format Podman OCI identity test
matthewgrossman 263a9f4
fix(cli): stay within SSH connection limit
matthewgrossman 4005df5
fix(sandbox): ensure OCI workspace is writable
matthewgrossman bf05429
fix(sandbox): harden OCI workspace resolution
matthewgrossman 7cd2bbc
fix(sandbox): honor supplementary workspace groups
matthewgrossman 0af4bad
fix(cli): address workspace review feedback
matthewgrossman ee85398
fix(podman): serialize image volume lifecycle
matthewgrossman d6ea9d5
test(e2e): cover OCI volumes with Podman
matthewgrossman 12b0bd6
test(e2e): build OCI fixture with active engine
matthewgrossman 6a1a875
test(e2e): cover upload directory merge
matthewgrossman ef03f1f
chore: merge main into OCI workdir stack
matthewgrossman a672d3c
fix(sandbox): preserve OCI workspace authority
matthewgrossman 1d2f22e
fix(podman): validate workdirs as sandbox identity
matthewgrossman ed0619a
fix(podman): narrow workspace probe lifecycle lock
matthewgrossman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -466,7 +466,6 @@ filesystem_policy: | |
| - /etc | ||
| - /var/log | ||
| read_write: | ||
| - /sandbox | ||
| - /tmp | ||
| - /dev/null | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -823,7 +823,6 @@ filesystem_policy: | |
| - /etc | ||
| - /var/log | ||
| read_write: | ||
| - /sandbox | ||
| - /tmp | ||
| - /dev/null | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do if the target directory exists?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the existing behavior is merge-ish: uploading a named directory into an existing directory of the same name overwrites matching entries but preserves unrelated entries. That behavior was already implemented, but undocumented; adding docs about that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uploading a named directory into an existing directory of the same name merges its contents: matching entries are overwritten, while unrelated remote entries are preserved. The skill now documents that behavior, and the E2E test verifies overwrite, addition, and preservation.