[codex] Add lychee docs link checks and stable source links#2159
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
|
/ok to test |
4 similar comments
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
5 similar comments
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
pre-commit.ci run |
|
/ok to test |
5 similar comments
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
99910b2 to
809534b
Compare
mdboom
left a comment
There was a problem hiding this comment.
Some minor comments, but nothing worth holding this up for.
| ------------------- | ||
|
|
||
| * `cuda.bindings 12.9.5 <https://nvidia.github.io/cuda-python/cuda-bindings/12.9.5/release/12.9.5-notes.html>`_ | ||
| * `cuda.bindings 12.9.5 <https://nvidia.github.io/cuda-python/cuda-bindings/latest/release/12.9.5-notes.html>`_ |
There was a problem hiding this comment.
This change doesn't seem right -- should this link to 12.9.5 always? If it intentionally goes to the latest, maybe remove the version from the displayed text?
There was a problem hiding this comment.
It intentionally goes to the latest published historical 12.9.5 release notes. It's still going to the v12.9.5 release notes, but from the latest docs render.
| ------------------- | ||
|
|
||
| * `cuda.bindings 12.9.6 <https://nvidia.github.io/cuda-python/cuda-bindings/12.9.6/release/12.9.6-notes.html>`_ | ||
| * `cuda.bindings 12.9.6 <https://nvidia.github.io/cuda-python/cuda-bindings/latest/release/12.9.6-notes.html>`_ |
|
/ok to test |
|
/ok to test |
|
What changed
.rstand.mdlinks through pre-commit.CUDA_PYTHON_DOCS_GITHUB_REFfor release, preview, and latest builds.cuda.bindings,cuda.core,cuda.pathfinder, andcuda-pythondocs.Split
This PR is now only the docs link-checking and stable source-link work. Generated
cuda.bindingspyobj-reference and pointer-rendering artifacts were split into #2167.The earlier Sphinx
linkcheckandcheck_example_links.pyexperiments were removed; lychee is the link checker for both local changed-link checks and rendered HTML checks.Validation
git diff --check origin/main...HEADpixi run pre-commit run actionlint --files .github/workflows/build-docs.yml .github/workflows/check-doc-links.yml .github/workflows/ci.ymlpixi run pre-commit run check-yaml --files .github/workflows/build-docs.yml .github/workflows/check-doc-links.yml .github/workflows/ci.ymlcuda.bindingsCython artifacts or generated pointer-rendering docs.