Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# Changelog
## v1.12.1 6/18/26
- Remove Azure client encoding and decoding

## v1.12.0 6/15/26
- Add Azure client

Expand Down
4 changes: 0 additions & 4 deletions src/nypl_py_utils/classes/azure_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,6 @@ def connect(self, retry_count=0, backoff_factor=5):
connection_str=connection_string,
timeout=30,
)
self.conn.setencoding(encoding="utf-8")
self.conn.setdecoding(
sqltype=mssql_python.SQL_WCHAR, encoding="utf-8"
)
return
except (mssql_python.InterfaceError,
mssql_python.OperationalError):
Expand Down
6 changes: 0 additions & 6 deletions tests/test_azure_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,6 @@ def test_connect_success(self, mock_azure_conn, test_instance):
test_instance.connect()

assert test_instance.conn == mock_azure_conn.return_value
mock_azure_conn.return_value.setencoding.assert_called_once_with(
encoding="utf-8"
)
mock_azure_conn.return_value.setdecoding.assert_called_once_with(
sqltype=mssql_python.SQL_WCHAR, encoding="utf-8"
)
# credentials are interpolated into connection string
connection_str = mock_azure_conn.call_args.kwargs["connection_str"]
assert connection_str == (
Expand Down
Loading