Skip to content

refactor: unify android runtime c++ layout#45

Open
DjDeveloperr wants to merge 11 commits into
codex/import-napi-android-history-lfsfrom
codex/plan-android-cpp-refactor
Open

refactor: unify android runtime c++ layout#45
DjDeveloperr wants to merge 11 commits into
codex/import-napi-android-history-lfsfrom
codex/plan-android-cpp-refactor

Conversation

@DjDeveloperr
Copy link
Copy Markdown
Collaborator

@DjDeveloperr DjDeveloperr commented Jun 6, 2026

Summary

  • move existing Apple FFI sources under NativeScript/ffi/objc and Android JNI Node-API interop under NativeScript/ffi/jni/napi
  • move Android runtime C++ into NativeScript/runtime/android and Android engine shims into NativeScript/napi/android
  • keep Java sources under platforms/android, restore Android SHERMES-compatible headers, and preserve the shared Hermes runtime surface used by Apple
  • update Android CMake/Gradle/test wiring, FFI generated-output paths, and engine-specific Android runtime specs for the unified layout

Validation

  • npm run build
  • npm run build:macos-cli
  • npm run check:ffi-boundaries
  • npm run test:macos -> SUCCESS: 713 specs, 0 failures, 10 skipped, 0 disabled
  • npm run test:ios -> SUCCESS: 713 specs, 0 failures, 13 skipped, 0 disabled
  • Android final matrix: ./gradlew --no-daemon --console=plain -Dandroid.builder.sdkDownload=false -b runtests.gradle runtestsAndVerifyResults -Pengine=<engine> -PndkDirectory=$ANDROID_NDK_ROOT -PndkVersion=27.1.12297006
  • Android XML summaries:
    • QUICKJS: 427 tests, 0 failures, 12 skipped
    • QUICKJS_NG: 427 tests, 0 failures, 12 skipped
    • HERMES: 399 tests, 0 failures, 52 skipped
    • SHERMES: 375 tests, 0 failures, 51 skipped
    • JSC: 396 tests, 0 failures, 36 skipped
    • PRIMJS: 427 tests, 0 failures, 12 skipped
    • V8-10: 427 tests, 0 failures, 12 skipped
    • V8-11: 427 tests, 0 failures, 12 skipped
    • V8-13: 427 tests, 0 failures, 12 skipped
  • git diff --check

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 6, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8ca8fed7-2781-42c8-b003-1fea29ce9f0e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/plan-android-cpp-refactor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@DjDeveloperr DjDeveloperr marked this pull request as ready for review June 6, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant