Skip to content

feat: add BatchMintNFT contract with upgradeable functionality and deployment scripts#97

Closed
Douglasacost wants to merge 2 commits into
mainfrom
douglasacost/open-erc-721-batch-mint
Closed

feat: add BatchMintNFT contract with upgradeable functionality and deployment scripts#97
Douglasacost wants to merge 2 commits into
mainfrom
douglasacost/open-erc-721-batch-mint

Conversation

@Douglasacost

Copy link
Copy Markdown
Collaborator
  • Introduced BatchMintNFT contract for public batch minting of NFTs, utilizing OpenZeppelin's upgradeable contracts.
  • Added deployment script for BatchMintNFT and an upgrade script for managing contract upgrades.
  • Updated foundry.toml and remappings for new dependencies.
  • Included comprehensive tests for minting, upgrading, and security checks.

@aliXsed

aliXsed commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Closing as superseded by #98 (merged).

#98 bundled this PR's entire content, and everything here is now in main:

  • BatchMintNFT.sol, both deploy/upgrade scripts, and the full test suite are byte-identical to main — except this branch still carries the unused MINTER_ROLE constant and the no-op burn() override, which were removed as review fixes on Bridge Indexing: Multichain support L1<>L2 sync data #98. Merging this PR would only re-introduce that dead code.
  • The subquery/mainnet-complete.ts datasource registration and const.ts entry landed via Bridge Indexing: Multichain support L1<>L2 sync data #98 as well (main's version additionally has the BridgeL2 datasource).
  • The .cspell.json / foundry.toml / remappings.txt changes are superseded by newer versions on main.

If role-gated minting was actually intended for BatchMintNFT, that's tracked in NodleCode/meta#213 (item 2) — re-introduce it there with a grant in the initializer and onlyRole enforcement on the mint functions, rather than by reviving this branch.

@aliXsed aliXsed closed this Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants