Restore markdown link checking#5445
Draft
nightt5879 wants to merge 1 commit into
Draft
Conversation
Re-enable Linkspector for newly added lines so broken links are caught without blocking unrelated pull requests on pre-existing or transient failures. Refs OAI#5414
Contributor
|
Thanks @nightt5879 , just a few comments immediately:
|
lornajane
marked this pull request as draft
July 24, 2026 09:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #5414
Changes:
filter_modetoadded.Rationale:
The previous
filemode checked the entire modified file, which meant pre-existing broken links or temporary failures on external websites could block otherwise unrelated PRs. Usingaddedlimits the check to broken links introduced by newly added lines.Impact:
Validation:
actionlintpassed.npm run validate-markdownpassed.npm testpassed: 8/8.git diff --checkpassed.Schema:
No schema changes are required.
AI disclosure:
Codex was used to analyze historical CI logs, update the workflow, and run validation checks. I personally reviewed and confirmed the changes.