[19.0][FIX] edi_queue_oca: propagate failed jobs to exchanges#321
Open
yankinmax wants to merge 1 commit into
Open
[19.0][FIX] edi_queue_oca: propagate failed jobs to exchanges#321yankinmax wants to merge 1 commit into
yankinmax wants to merge 1 commit into
Conversation
When an EDI queue job reached its maximum retries, only the queue job was marked as failed while the related exchange remained pending. Propagate terminal send, receive, and process job failures to the corresponding exchange error state, including the exception message and traceback.
Contributor
Author
|
Hello @simahawk can you pls take a look? |
SilvioC2C
approved these changes
Jul 13, 2026
Ricardoalso
reviewed
Jul 15, 2026
|
|
||
| def write(self, vals): | ||
| result = super().write(vals) | ||
| if vals.get("state") == "failed": |
Contributor
There was a problem hiding this comment.
Maybe there’s an opportunity to create an "on-failure" hook in the queue_job module
https://github.com/OCA/queue/blob/19.0/queue_job/models/queue_job.py#L268
|
|
||
| def write(self, vals): | ||
| result = super().write(vals) | ||
| if vals.get("state") == "failed": |
Contributor
There was a problem hiding this comment.
Direct SQL updates executed by the queue_job runner will bypass this logic https://github.com/OCA/queue/blob/19.0/queue_job/jobrunner/runner.py#L217
In the situation where the number of retries exceeds the maximum allowed, the job is marked as "failed" with the error "JobFoundDead."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an EDI queue job reached its maximum retries, only the queue job was marked as failed while the related exchange remained pending.
Propagate terminal send, receive, and process job failures to the corresponding exchange error state, including the exception message and traceback.