Skip to content

[19.0][IMP] webservice, webservice_server_env: neutralize webservice backend credentials#145

Open
yankinmax wants to merge 2 commits into
OCA:19.0from
camptocamp:imp-webservice-add-neutralize
Open

[19.0][IMP] webservice, webservice_server_env: neutralize webservice backend credentials#145
yankinmax wants to merge 2 commits into
OCA:19.0from
camptocamp:imp-webservice-add-neutralize

Conversation

@yankinmax

Copy link
Copy Markdown

No description provided.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @etobella,
some modules you are maintaining are being modified, check this out!

@yankinmax yankinmax force-pushed the imp-webservice-add-neutralize branch 2 times, most recently from ea302cf to 6502847 Compare July 9, 2026 15:15
@OCA-git-bot OCA-git-bot added the mod:webservice_server_env Module webservice_server_env label Jul 9, 2026
@yankinmax yankinmax force-pushed the imp-webservice-add-neutralize branch from 14de1c4 to a29b302 Compare July 10, 2026 05:39
@OCA-git-bot OCA-git-bot removed the mod:webservice_server_env Module webservice_server_env label Jul 10, 2026
…entials

If both webservice and server_environment are installed we also need neutralization for webservice_server_env
so the plain columns nulled by webservice/data/neutralize.sql can be properly cleared
@OCA-git-bot OCA-git-bot added the mod:webservice_server_env Module webservice_server_env label Jul 10, 2026
@yankinmax yankinmax changed the title [19.0][IMP] webservice: neutralize webservice backend credentials [19.0][IMP] webservice, webservice_server_env: neutralize webservice backend credentials Jul 10, 2026

@Ricardoalso Ricardoalso left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yankinmax 🙏

Comments related to an open PR that will conflict

password = NULL,
api_key = NULL,
oauth2_clientid = NULL,
oauth2_client_secret = NULL,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this change (https://github.com/OCA/web-api/pull/143/changes), we will also need to update oauth2_client_auth_method = NULL

-- into non-stored fields backed by the server_env_defaults JSON column
-- this neutralization is needed if both webservice and server_environment are installed,
-- so the plain columns nulled by webservice/data/neutralize.sql can be properly cleared)
UPDATE webservice_backend

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:webservice_server_env Module webservice_server_env mod:webservice Module webservice series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants