[19.0][IMP] webservice, webservice_server_env: neutralize webservice backend credentials#145
Open
yankinmax wants to merge 2 commits into
Open
[19.0][IMP] webservice, webservice_server_env: neutralize webservice backend credentials#145yankinmax wants to merge 2 commits into
yankinmax wants to merge 2 commits into
Conversation
Contributor
|
Hi @etobella, |
ea302cf to
6502847
Compare
14de1c4 to
a29b302
Compare
…entials If both webservice and server_environment are installed we also need neutralization for webservice_server_env so the plain columns nulled by webservice/data/neutralize.sql can be properly cleared
Ricardoalso
reviewed
Jul 10, 2026
Ricardoalso
left a comment
There was a problem hiding this comment.
Thanks @yankinmax 🙏
Comments related to an open PR that will conflict
| password = NULL, | ||
| api_key = NULL, | ||
| oauth2_clientid = NULL, | ||
| oauth2_client_secret = NULL, |
There was a problem hiding this comment.
After this change (https://github.com/OCA/web-api/pull/143/changes), we will also need to update oauth2_client_auth_method = NULL
| -- into non-stored fields backed by the server_env_defaults JSON column | ||
| -- this neutralization is needed if both webservice and server_environment are installed, | ||
| -- so the plain columns nulled by webservice/data/neutralize.sql can be properly cleared) | ||
| UPDATE webservice_backend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.