Skip to content

chore: [SDK-4213] route consumer call-sites through serial IO (part 3/3)#2674

Open
abdulraqeeb33 wants to merge 1 commit into
ar/sdk-4213-part2from
ar/sdk-4213-part3
Open

chore: [SDK-4213] route consumer call-sites through serial IO (part 3/3)#2674
abdulraqeeb33 wants to merge 1 commit into
ar/sdk-4213-part2from
ar/sdk-4213-part3

Conversation

@abdulraqeeb33

Copy link
Copy Markdown
Contributor

Summary

Part 3 of 3 (final) of the SDK-4213 stack. Stacked on #2673 — review/merge last.

Updates the feature-flag consumers to the unconditional async API:

  • BackgroundManager focus/unfocus, SessionService, NotificationsManager, NotificationPermissionController polling, and OneSignalCrashUploaderWrapper dispatch through the serial IO helper so lifecycle/Binder work never runs inline on the main thread.
  • Updates corresponding tests; strips stale ticket references from comments.

The tip of this PR reproduces the original ar/sdk-4213 net diff exactly.

Test plan

  • CI green
  • consumer + notifications unit tests pass

Made with Cursor

Final part of the SDK-4213 stack. Updates the feature-flag consumers to the
unconditional async API: BackgroundManager focus/unfocus, SessionService,
NotificationsManager, NotificationPermissionController polling, and
OneSignalCrashUploaderWrapper now dispatch through the serial IO helper so
lifecycle/Binder work never runs inline on the main thread. Updates the
corresponding tests and strips stale ticket references from comments.

Part 3 of 3. Stacked on part 2; merge last.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

Copy link
Copy Markdown
Contributor

📊 Diff Coverage Report

Diff Coverage Report (Changed Lines Only)

Gate: aggregate coverage on changed executable lines must be ≥ 80% (JaCoCo line data for lines touched in the diff).

Changed Files Coverage

  • BackgroundManager.kt: 2/2 touched executable lines (100.0%) (4 touched lines in diff)
  • OneSignalCrashUploaderWrapper.kt: 0/3 touched executable lines (0.0%) (3 touched lines in diff)
    • 3 uncovered touched lines in this file
  • SessionService.kt: 2/2 touched executable lines (100.0%) (5 touched lines in diff)
  • NotificationsManager.kt: 0/1 touched executable lines (0.0%) (2 touched lines in diff)
    • 1 uncovered touched lines in this file
  • NotificationPermissionController.kt: 0/2 touched executable lines (0.0%) (3 touched lines in diff)
    • 2 uncovered touched lines in this file

Overall (aggregate gate)

4/10 touched executable lines covered (40.0% — requires ≥ 80%)

Per-file detail (informational; gate is aggregate above):

  • OneSignalCrashUploaderWrapper.kt: 0.0% (3 uncovered touched lines)

  • NotificationsManager.kt: 0.0% (1 uncovered touched lines)

  • NotificationPermissionController.kt: 0.0% (2 uncovered touched lines)

❌ Coverage Check Failed

Aggregate coverage on touched lines is 40.0% (minimum 80%).

📥 View workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant