chore: [SDK-4213] route consumer call-sites through serial IO (part 3/3)#2674
Open
abdulraqeeb33 wants to merge 1 commit into
Open
chore: [SDK-4213] route consumer call-sites through serial IO (part 3/3)#2674abdulraqeeb33 wants to merge 1 commit into
abdulraqeeb33 wants to merge 1 commit into
Conversation
Final part of the SDK-4213 stack. Updates the feature-flag consumers to the unconditional async API: BackgroundManager focus/unfocus, SessionService, NotificationsManager, NotificationPermissionController polling, and OneSignalCrashUploaderWrapper now dispatch through the serial IO helper so lifecycle/Binder work never runs inline on the main thread. Updates the corresponding tests and strips stale ticket references from comments. Part 3 of 3. Stacked on part 2; merge last. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
📊 Diff Coverage ReportDiff Coverage Report (Changed Lines Only)Gate: aggregate coverage on changed executable lines must be ≥ 80% (JaCoCo line data for lines touched in the diff). Changed Files Coverage
Overall (aggregate gate)4/10 touched executable lines covered (40.0% — requires ≥ 80%) Per-file detail (informational; gate is aggregate above):
❌ Coverage Check FailedAggregate coverage on touched lines is 40.0% (minimum 80%). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 3 of 3 (final) of the SDK-4213 stack. Stacked on #2673 — review/merge last.
Updates the feature-flag consumers to the unconditional async API:
BackgroundManagerfocus/unfocus,SessionService,NotificationsManager,NotificationPermissionControllerpolling, andOneSignalCrashUploaderWrapperdispatch through the serial IO helper so lifecycle/Binder work never runs inline on the main thread.The tip of this PR reproduces the original
ar/sdk-4213net diff exactly.Test plan
Made with Cursor