Skip to content

fix bug in Python version glob expansion (passing incorrect repository URL to supported-pythons)#405

Merged
zacharyburnett merged 1 commit into
OpenAstronomy:mainfrom
zacharyburnett:fix/supported-pythons-repo
Jun 22, 2026
Merged

fix bug in Python version glob expansion (passing incorrect repository URL to supported-pythons)#405
zacharyburnett merged 1 commit into
OpenAstronomy:mainfrom
zacharyburnett:fix/supported-pythons-repo

Conversation

@zacharyburnett

@zacharyburnett zacharyburnett commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

supported-pythons should be using the originating repository's URL (github.repository), but instead it's using OpenAstronomy/github-actions-workflows (github.workflow_repository): https://github.com/spacetelescope/jwst/actions/runs/27967972018/job/82766673179?pr=10636

this was not revealed in testing because we test inside this repository, so github.repository and github.workflow_repository are identical 😵‍💫. Next time I should do more thorough testing with a temporary branch in another repo

@zacharyburnett zacharyburnett self-assigned this Jun 22, 2026
@zacharyburnett zacharyburnett changed the title fix bug in passing reusable workflow repo to supported-pythons fix bug in Python version glob expansion (passing incorrect repository URL to supported-pythons) Jun 22, 2026
@zacharyburnett

zacharyburnett commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

tested at https://github.com/spacetelescope/jwst/actions/runs/27969433592/job/82771659155, this works as expected now. I'll make a v3.0.1 release 😓

@zacharyburnett zacharyburnett merged commit e5af21e into OpenAstronomy:main Jun 22, 2026
89 of 90 checks passed
@zacharyburnett zacharyburnett deleted the fix/supported-pythons-repo branch June 22, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant