OIDC#2854
Merged
Merged
Conversation
Add a section comparing four allowlist policies (per instance, per app, per app x environment, per tenant) with an implications matrix, rotation guidance, and a note on the future Consumer-bound allowlist direction. Recommends one Google OAuth client per app per environment.
…pin it with tests The policy section claimed OBP auto-creates one Consumer per user per Google client, keyed by <sub, azp>. That described the original implementation and the stale scaladoc on OAuth2.getOrCreateConsumer, not the current code: MappedConsumersProvider.getOrCreateConsumer resolves by consumerId, then by Consumer.key == azp (pre-registered consumer takes priority, displacing a stale auto-created twin), then by the (azp, iss) pair — one Consumer per OAuth client per issuer, with sub stored but not part of the lookup key. - OAUTH2_IDENTITY_PROVIDERS.md: fix the implementation-fact paragraph, matrix row and policy 1/2 implications (per-app rate limits, metrics and the runtime Consumer disable switch already work at (azp, iss) granularity); rewrite 'Beyond the flat list' as 'Binding client IDs to registered Consumers (half implemented)' — attachment via key == azp exists today, registration-based rejection does not. - OAuth2.scala: replace the stale <sub, azp> scaladoc with the actual lookup order (comment-only, no behaviour change). - OAuth2ConsumerResolutionTest (new, 6 scenarios, all green): (azp, iss) granularity incl. sub-not-a-key, per-issuer separation, name-claim / description naming, azp-derived consumerId, pre-registered-consumer priority, stale-consumer displacement.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.