Limit poll migration to functional C++ changes and drop rebuilt binaries from PR#1
Open
Copilot wants to merge 4 commits into
Open
Limit poll migration to functional C++ changes and drop rebuilt binaries from PR#1Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
Copilot created this pull request from a session on behalf of
jens-maus
June 29, 2026 09:54
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update narrows the PR to the intended functional change only: replacing
select()-based waits withpoll()in the affected connection paths. It removes unintended binary refreshes and whitespace-only churn so review focuses on behavior changes.Scope cleanup (no binary artifacts)
Functional update:
LanConnection/src/libUnifiedLanComm/src/LanConnection.cpppoll()on non-Windows instead ofselect().EINTR.INT_MAXbefore passing topoll().Functional update:
UpstreamCharConnection/src/multimacd/UpstreamCharConnection.cppselect()fd-set flow withpollfd-based waiting.pollrevents.